Sub-menu items are doubled

This commit fixed a problem with breadcrumb menu items inserted through PHP instead of being part of the site tree. It looks like the problem is in line 459. It should probably be changed to something like this:

if ($this->{'items_' . $id}->parent != $this->{'items_' . $ref}) {
    $this->{'items_' . $ref}->children[] =& $this->{'items_' . $id};
    $this->{'items_' . $id}->parent =& $this->{'items_' . $ref};
}

That way it doesn't add the menu item to ->children[] if it's already a child of the parent item. I haven't tested that out, but it looks like that code might fix it. Let me know what menu/nav box to use to recreate the problem and I can test that out.

I saw the problem in nav/list, nav/common and nav/sitemap.

It still doesn't work with your fix. With vac/common, it gives something like

• A
• B
  • a
  • b
  • a
  • b

• C

• A

• B
  • a
    • 1
    • 2
  • b

• C

• A

• B
  • a
    • 1
      • i
      • ii
      • i
      • ii
    • 2
• C

Oups, it isn't obvious, bt there are 3 examples in the preceding post. The first and the third are with items doubled.