Sitellite Sitellite CMS → 5.0.3

Comments and changes to this ticket

• 

  Charles Brunet July 27th, 2009 @ 03:51 PM

  • State changed from “new” to “open”

  John, could you check what that commit was supposed to do. Can we revert it?

• 

  lux July 27th, 2009 @ 04:25 PM

  This commit fixed a problem with breadcrumb menu items inserted through PHP instead of being part of the site tree. It looks like the problem is in line 459. It should probably be changed to something like this:

  if ($this->{'items_' . $id}->parent != $this->{'items_' . $ref}) {
      $this->{'items_' . $ref}->children[] =& $this->{'items_' . $id};
      $this->{'items_' . $id}->parent =& $this->{'items_' . $ref};
  }
  

  That way it doesn't add the menu item to ->children[] if it's already a child of the parent item. I haven't tested that out, but it looks like that code might fix it. Let me know what menu/nav box to use to recreate the problem and I can test that out.

• 

  Charles Brunet July 27th, 2009 @ 05:01 PM

  I saw the problem in nav/list, nav/common and nav/sitemap.

  It still doesn't work with your fix. With vac/common, it gives something like

  • A
  • B
    • a
    • b
    • a
    • b

  • C

  • A

  • B
    • a
      • 1
      • 2
    • b

  • C

  • A

  • B
    • a
      • 1
        • i
        • ii
        • i
        • ii
      • 2
  • C
• 

  Charles Brunet July 27th, 2009 @ 05:02 PM

  Oups, it isn't obvious, bt there are 3 examples in the preceding post. The first and the third are with items doubled.

• 

  lux August 4th, 2009 @ 02:24 PM

  • State changed from “open” to “resolved”

  This commit I just made seems to correct it without sacrificing the fix the other commit was for.

  http://github.com/lux/sitellite/commit/2fa4707100132c513c2facc7f51c...

• 

  Charles Brunet August 4th, 2009 @ 02:48 PM

  • State changed from “resolved” to “open”

  I tested it, and now, list and common nav boxes only show the 2 first levels of menus. I cannot see level 3 menus and more...

• 

  Charles Brunet August 6th, 2009 @ 03:02 PM

  • Milestone set to “5.0.3”
• 

  lux October 18th, 2010 @ 10:09 AM

  • State changed from “open” to “resolved”
  • Milestone order changed from “0” to “0”

  I believe this is fixed. I can't seem to get it to show duplicates, and list, common and sitemap nav boxes show me 5+ levels in testing.