#174 ✓resolved
semias

CMS cancel

Reported by semias | March 11th, 2011 @ 03:50 AM | in 5.0.4 (closed)

In some collection editing scripts is a typo error in EncodeURIComponent, no capital "E".

page_add_script ('
    function cms_cancel_unlock (f, collection, key) {
        onbeforeunload_form_submitted = true;
        if (arguments.length == 0) {
            window.location.href = "' . site_prefix () . '/index/cms-unlock-action?collection=" + collection + "&key=" + key + "&return=' . site_prefix () . '/index/cms-app";
        } else {
            if (f.elements[\'_return\'] && f.elements[\'_return\'].value.length > 0) {
                window.location.href = "' . site_prefix () . '/index/cms-unlock-action?collection=" + collection + "&key=" + key + "&return=" + EncodeURIComponent
(f.elements[\'_return\'].value);
            } else {
                window.location.href = "' . site_prefix () . '/index/cms-unlock-action?collection=" + collection + "&key=" + key + "&return=' . site_prefix () . '/index/cms-app";
            }
        }
        return false;
    }
// etc.
');

EncodeURIComponent is undefined --> encodeURIComponent (with non capital "e") is the correct JavaScript function.

Comments and changes to this ticket

  • semias

    semias March 11th, 2011 @ 04:06 AM

    • State changed from “open” to “resolved”

    Affected files:

    inc/app/sitepresenter/forms/edit/index.php
    inc/app/sitestudy/forms/edit/index.php
    inc/app/cms/forms/edit/sitellite_filesystem/index.php
    inc/app/cms/conf/properties.php
    inc/app/news/forms/edit/index.php
    inc/app/siteevent/forms/edit/index.php
    

    Command used: grep -r -n EncodeURIComponent *

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

The Sitellite web content management system.

People watching this ticket

Pages